Skip to content

Merged with master #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2019
Merged

Merged with master #727

merged 1 commit into from
Dec 13, 2019

Conversation

hiranya911
Copy link
Contributor

@bojeil-google I needed to make some changes to following files to satisfy the compiler. PTAL:

both modified:   src/auth/user-record.ts
both modified:   test/unit/auth/auth-api-request.spec.ts
modified:   src/auth/auth-api-request.ts
modified:   src/auth/user-import-builder.ts
modified:   test/unit/auth/user-import-builder.spec.ts
modified:   test/unit/auth/user-record.spec.ts

Other changes are straight up merge from master.

@bojeil-google bojeil-google merged commit 34e2ab9 into auth-mfa Dec 13, 2019
@bojeil-google
Copy link
Contributor

Thanks for taking care of this!

This was referenced Feb 1, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bojeil-google bojeil-google bojeil-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bojeil-google bojeil-google

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiranya911 @bojeil-google